feat(wsctl): add project configuration cmd #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunshenshi
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4195 +/- ##
==========================================
+ Coverage 75.38% 76.63% +1.25%
==========================================
Files 303 340 +37
Lines 25923 29260 +3337
==========================================
+ Hits 19541 22423 +2882
- Misses 5360 5732 +372
- Partials 1022 1105 +83 ☔ View full report in Codecov by Sentry. |
Liuhaai
reviewed
Mar 20, 2024
ioctl/cmd/ws/wsprojectconfig.go
Outdated
| Short: config.TranslateInLang(wsCodeConvertShorts, config.UILanguage), | ||
| // wsProjectConfig represents the generate w3bstream project configuration command | ||
| wsProjectConfig = &cobra.Command{ | ||
| Use: "configuration", |
Liuhaai
reviewed
Mar 20, 2024
| @@ -42,8 +42,12 @@ var ( | |||
| if err != nil { | |||
| return errors.Wrap(err, "failed to get flag expand-param") | |||
| } | |||
| outputFile, err := cmd.Flags().GetString("output-file") | |||
There was a problem hiding this comment.
will err be returned without output flag?
There was a problem hiding this comment.
keep same with other param's error
Liuhaai
reviewed
Mar 20, 2024
| wasm vmType = "wasm" // wasm vm | ||
| ) | ||
|
|
||
| func stringToVMType(vmType string) (vmType, error) { |
There was a problem hiding this comment.
this should be/has been done at API side
Liuhaai
approved these changes
Mar 21, 2024
huangzhiran
approved these changes
Mar 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: