Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api]Support for tracer and tracerConfig in debug_traceTransaction API #4216

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

millken
Copy link
Contributor

@millken millken commented Mar 29, 2024

Description

Support for tracer and tracerConfig in debug_traceTransaction API

refer : https://geth.ethereum.org/docs/developers/evm-tracing/built-in-tracers

example

curl -X POST http://127.0.0.1:15014/ -H "Content-Type:application/json" --data '{
    "jsonrpc":"2.0",
                "method":"debug_traceTransaction",
                "params":["0xc255ed60f69a7a78768165f0784d5cbf37a0b8aa87e01639d3817204678d829f", {"tracer": "callTracer", "tracerConfig": { "onlyTopCall": false, "withLog":true }}],
    "id":1
}'

Fixes #4209

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.75%. Comparing base (d716bb9) to head (977d550).
Report is 24 commits behind head on master.

❗ Current head 977d550 differs from pull request most recent head 8e8c0e7. Consider uploading reports for the commit 8e8c0e7 to get more accurate results

Files Patch % Lines
api/web3server.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4216      +/-   ##
==========================================
+ Coverage   76.51%   76.75%   +0.24%     
==========================================
  Files         340      340              
  Lines       29273    29257      -16     
==========================================
+ Hits        22397    22455      +58     
+ Misses       5761     5698      -63     
+ Partials     1115     1104      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@envestcc envestcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember #3931 has enabled tracer for debug_traceCall, and this is for debug_traceTransaction.
Is there any other debug_* api need to support? Can you list them if exists

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dustinxie dustinxie merged commit af6825d into iotexproject:master Apr 15, 2024
3 checks passed
dustinxie added a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for callTracer in debug_traceTransaction
4 participants