Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way to hash genesis config #691

Merged
merged 1 commit into from Mar 7, 2019
Merged

Improve the way to hash genesis config #691

merged 1 commit into from Mar 7, 2019

Conversation

zjshen14
Copy link
Contributor

@zjshen14 zjshen14 commented Mar 7, 2019

Based on protobuf instead of file checksum

@zjshen14 zjshen14 requested a review from a team as a code owner March 7, 2019 21:32
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #691 into master will decrease coverage by 0.21%.
The diff coverage is 3.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   60.19%   59.97%   -0.22%     
==========================================
  Files         132      132              
  Lines       12588    12633      +45     
==========================================
  Hits         7577     7577              
- Misses       3963     4010      +47     
+ Partials     1048     1046       -2
Impacted Files Coverage Δ
blockchain/genesis/genesis.go 42.58% <0%> (-19.24%) ⬇️
blockchain/blockchain.go 49.74% <100%> (ø) ⬆️
db/trie/branchnode.go 65.59% <0%> (-1.61%) ⬇️
consensus/scheme/rolldpos/rolldposctx.go 75.57% <0%> (+0.45%) ⬆️
db/trie/extensionnode.go 59.32% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c206ebf...40bf683. Read the comment docs.

@zjshen14 zjshen14 merged commit e598611 into iotexproject:master Mar 7, 2019
zjshen14 added a commit that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants