Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android WebView doesn't show when set style={{ width: ... }} #88

Merged
merged 1 commit into from Oct 19, 2018

Conversation

notjiam
Copy link
Contributor

@notjiam notjiam commented Oct 18, 2018

I have an issue when I set props style.width
<AutoHeightWebView
style={{ width: 300 }}
...
/>

In some case, stage.height can update with null and WebView doesn't show.
I add some condition to check before an update stage.

Thank you!

I have an issue when I set props style.width
<AutoHeightWebView
style={{ width: 300 }}
...
/>

In some case,  stage.height can update with null and WebView doesn't show.
I add some condition to check before an update stage.

Thank you!
@notjiam notjiam mentioned this pull request Oct 18, 2018
@iou90 iou90 merged commit ce29b11 into iou90:master Oct 19, 2018
@realchiu
Copy link

realchiu commented Nov 8, 2018

Android with RN0.57.4 and AutoHeightWebView 0.10.5 still get this error when setting width: '100%'.
It works when I set width: 100 (or whatever number but not '100%').

@iou90
Copy link
Owner

iou90 commented Nov 9, 2018

@notjiam Could you provide a demo for this case?

mnramo added a commit to mnramo/react-native-autoheight-webview that referenced this pull request May 13, 2023
idealdev00000 added a commit to idealdev00000/WebView-ReactNative that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants