Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Merkle Proofs document #51

Closed
orkunkl opened this issue Jul 29, 2019 · 6 comments · Fixed by #61
Closed

Update Merkle Proofs document #51

orkunkl opened this issue Jul 29, 2019 · 6 comments · Fixed by #61

Comments

@orkunkl
Copy link
Contributor

orkunkl commented Jul 29, 2019 •
edited

On Queries page, its mentioned that Merkle proofs are not implemented as of weave v0.14.0. What is the status of the feature? If it is implemented can you point me to the code?
Related to #42
@orkunkl
Copy link
Contributor Author

orkunkl commented Jul 29, 2019

@ethanfrey @alpe @husio @ruseinov

@ethanfrey
Copy link
Contributor

It is not implemented yet (as of v0.20.0). Never a priority...

I am unsure if it will ever be implemented, if anyone on the team feels confident to do so. (But it would be very good to do so imo)

@orkunkl
Copy link
Contributor Author

orkunkl commented Jul 30, 2019

So I am updating Proofs are not yet implemented as of weave v0.14 to v0.20 and leave this issue open

@orkunkl orkunkl mentioned this issue Jul 30, 2019
Merged
@husio
Copy link
Contributor

husio commented Jul 31, 2019

Maybe drop the version information completely. Merkle proofs are not implemented. We do not know when we will provide this functionality.

@alpe
Copy link

alpe commented Jul 31, 2019

Maybe link to the ticket iov-one/weave#5 ?

@orkunkl
Copy link
Contributor Author

orkunkl commented Jul 31, 2019

@alpe nice idea 👍

@orkunkl orkunkl mentioned this issue Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove merkle root weave version and refer to issue iov-one/docs
4 participants
@husio @alpe @ethanfrey @orkunkl