Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and add some interesting tslint rules #706

Closed
webmaster128 opened this issue Jan 19, 2019 · 3 comments
Closed

Check and add some interesting tslint rules #706

webmaster128 opened this issue Jan 19, 2019 · 3 comments
Assignees
Labels
good first issue Good for newcomers
Projects

Comments

@webmaster128
Copy link
Contributor

webmaster128 commented Jan 19, 2019

Interesting stuff we do not use yet: microsoft/TypeScript#29288 (comment)

@webmaster128
Copy link
Contributor Author

webmaster128 commented Jan 22, 2019

Those rules that require type information that are not available in the current TSLint plugin for VSCode:

Since we don't want to lint in every build due to performance reasons, we first need to migrate from vscode-tslint to vscode-typescript-tslint-plugin. See differences with the vscode-TSLint extension

@webmaster128
Copy link
Contributor Author

But when we have no-floating-promises, this code

export function foo(): void {
  sleep(3);
}

leads to

ERROR: (no-floating-promises) /iov-core/packages/iov-bns/src/bnsconnection.spec.ts[60, 3]: Promises must be handled appropriately

Great stuff!

@webmaster128 webmaster128 added the good first issue Good for newcomers label Jan 23, 2019
@webmaster128 webmaster128 added this to To do in Development via automation Feb 27, 2019
@webmaster128 webmaster128 moved this from To do to Next sprint in Development Feb 27, 2019
@webmaster128 webmaster128 moved this from Next sprint to In progress in Development Feb 27, 2019
@webmaster128 webmaster128 moved this from In progress to Next sprint in Development Feb 27, 2019
@willclarktech willclarktech moved this from Next sprint to In progress in Development Feb 27, 2019
@willclarktech willclarktech moved this from In progress to Needs review in Development Feb 28, 2019
@webmaster128
Copy link
Contributor Author

Done in #789

Skipping strict-type-predicates as it does not work well with all our type checkers that use fake casts.

Development automation moved this from Needs review to Done Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Development
  
Done
Development

No branches or pull requests

2 participants