Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interesting tslint rules #789

Merged
merged 5 commits into from
Feb 28, 2019
Merged

Add interesting tslint rules #789

merged 5 commits into from
Feb 28, 2019

Conversation

willclarktech
Copy link
Contributor

I didn't add strict-type-predicates so far, because it basically entailed removing some checks and/or helper functions and I wasn't fully confident about that.

Other things to think about:

  • async/await changes might require additional changes I'm unaware of
  • Maybe we should remove support for the MetaMask 'HD Key Tree' implementation since it's deprecated

@willclarktech willclarktech added the wip work in progress label Feb 28, 2019
@willclarktech willclarktech added this to Needs review in Development via automation Feb 28, 2019
webmaster128
webmaster128 reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

packages/iov-faucets/tslint.json Show resolved Hide resolved
packages/iov-bns/src/types.ts Show resolved Hide resolved
packages/iov-ethereum/src/ethereumconnection.ts Outdated Show resolved Hide resolved
Development automation moved this from Needs review to Reviewer approved Feb 28, 2019
@willclarktech willclarktech removed the wip work in progress label Feb 28, 2019
@webmaster128 webmaster128 merged commit e0c1d43 into master Feb 28, 2019
Development automation moved this from Reviewer approved to Done Feb 28, 2019
@webmaster128 webmaster128 deleted the 706-tslint-rules branch February 28, 2019 13:57
@webmaster128 webmaster128 mentioned this pull request Feb 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willclarktech @webmaster128