Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #1012 - Delete account #1066

Merged
merged 16 commits into from
Mar 24, 2020
Merged

Feature #1012 - Delete account #1066

merged 16 commits into from
Mar 24, 2020

Conversation

albertandrejev
Copy link
Contributor

Closes #1012.

@albertandrejev albertandrejev self-assigned this Mar 23, 2020
@albertandrejev albertandrejev changed the base branch from master to milestone/account-module-support March 23, 2020 21:31
@abefernan abefernan added this to Needs review/In review in Frontend development via automation Mar 24, 2020
@abefernan abefernan moved this from Needs review/In review to Doing in Frontend development Mar 24, 2020
@albertandrejev
Copy link
Contributor Author

Not possible to implement iovname deletion. Migration to new BNS account module required.

@albertandrejev albertandrejev mentioned this pull request Mar 24, 2020
Open
abefernan
abefernan approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@abefernan abefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! You can create a ticket for Iovname deletion and put a blocked tag on it.

@abefernan abefernan moved this from Doing to Needs review/In review in Frontend development Mar 24, 2020
@albertandrejev
Copy link
Contributor Author

Already done #1068

@albertandrejev albertandrejev merged commit d7b266a into milestone/account-module-support Mar 24, 2020
Frontend development automation moved this from Needs review/In review to Done Mar 24, 2020
@albertandrejev albertandrejev deleted the feature/#1012-delete-account branch March 24, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abefernan abefernan abefernan approved these changes

Assignees

@albertandrejev albertandrejev

Labels
Bierzo Wallet Feature
Projects
Frontend development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starname in Wallet: Delete iovname/starnames/names
2 participants
@albertandrejev @abefernan