This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Fix #193 - Responsive version Header, Login and signup fixes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment: Storybook book automatic deployment: |
src/components/hoc/OpenHoc.tsx
Outdated
| @@ -19,7 +19,10 @@ export function openHoc<T>( | |||
| { open: false, visited: false }, | |||
| { | |||
| toggle: (state: OpenType) => () => ({ open: !state.open, visited: true }), | |||
| clickAway: () => () => ({ open: false, visited: true }), | |||
| clickAway: () => () => { | |||
| console.log("On clickaway"); | |||
| <Typography variant="h4" color="primary" inline> | ||
| {`${primaryTitle}\u00a0`} | ||
| {`${primaryTitle} `} |
There was a problem hiding this comment.
Maybe it is better to use {primaryTitle} ?
| {phone => ( | ||
| <Block className={classes.container} padding={phone ? "lg" : "xxl"} margin="xxl" align="right"> | ||
| <Typography variant="subtitle1" inline> | ||
| {"Don't have an IOV wallet?\u00a0"} |
There was a problem hiding this comment.
what do you think about using instead of \u00a0 i think it is more easy to read and will allow you to use it directly in code without curly braces and variable substitution.
albertandrejev
suggested changes
Jan 8, 2019
apanizo
force-pushed
the
fix/#193-responsive-fixes
branch
from
bfd7bb1
to
051c16e
Compare
|
Travis automatic deployment: Storybook book automatic deployment: |
Development - Demo Wallet 📯
automation
moved this from Needs review
to Reviewer approved
Jan 9, 2019
albertandrejev
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements mostly all bugs referenced in #193, basically, it solves bugs reported in Header's Menu, login and signup views, for making them more responsive in phones.
Also, by reference, it closes #193 #176 #175 #174 #180 #173
Basically, it solves: