Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time with escrow #392

Closed
alpe opened this issue Mar 11, 2019 · 1 comment
Closed

Support time with escrow #392

alpe opened this issue Mar 11, 2019 · 1 comment
Assignees

Comments

@alpe
Copy link
Contributor

alpe commented Mar 11, 2019

Is your feature request related to a problem? Please describe.

Allow use of header time rather than header height as a trigger for timeout. Since tendermint 0.27 the timestamp in the header should be considered "BFT time" (cannot be faked without collusion of majority of the nodes), and is a reliable and more predictable indicator than block height (especially when no-empty-blocks is enabled)

Copied from #310

@ethanfrey
Copy link
Contributor

Please note that the time is taken from the block header.
This means we also need to set and read this value from the header in our app and the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants