Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance warning in Xcode 14 #35

Open
Amnell opened this issue Aug 4, 2022 · 14 comments
Open

Performance warning in Xcode 14 #35

Amnell opened this issue Aug 4, 2022 · 14 comments

Comments

@Amnell
Copy link

Amnell commented Aug 4, 2022

When fetching the blackbox string Xcode throws a performance warning:

"This method can cause UI unresponsiveness if invoked on the main thread. Instead, consider waiting for the -locationManagerDidChangeAuthorization: callback and checking authorizationStatus first."

image

@ejubber
Copy link

ejubber commented Sep 14, 2022

+1 on this

@sara-porter-iovation
Copy link

Thank you! Can you tell me if this is from one of our included sample apps (specifically the swift) or from your own application and what version of Xcode 14 you're using? I'm working on tracking it down and would appreciate any details you can provide.

@Amnell
Copy link
Author

Amnell commented Sep 15, 2022

Thank you! Can you tell me if this is from one of our included sample apps (specifically the swift) or from your own application and what version of Xcode 14 you're using? I'm working on tracking it down and would appreciate any details you can provide.

This is in our own applications. Swift. Xcode 14 GM (and all Xcode 14 beta versions prior to that).

@DNCGraef
Copy link

DNCGraef commented Oct 5, 2022

+1

Any update on this issue? It would be good to get this warning addressed

@thanospapazoglou
Copy link

+1

Any update on this?

@enasaz9
Copy link

enasaz9 commented Jan 27, 2023

+1
@sara-porter-iovation any updates?

@markph0204
Copy link

+1
Any update would be helpful for planning and timely resolution to this matter please.

@herculesjr
Copy link

+1 on this

@CraigSiemens
Copy link

CraigSiemens commented Mar 16, 2023

We're running into this issue in our app as well.

The issue is that the sdk is accessing authorizationStatus directly instead of waiting for the delegate method to be called. This causes the location manager to have to synchronously wait to get the authorization status from iOS. While this happens, the app will hang and be unresponsive until it the authorization status is returned. We've seen the app be frozen for 2+ seconds when this happens.

I'd suspect the solution would be for FraudForce.start() to create the location manager and add the delegate. Then when blackbox() is called, the authorization status should have already been received.

@yhkaplan
Copy link

@mark-sanvitale-iovation or anyone please take a look

@idrougge
Copy link

This issue has been ignored for almost a year. Is this product abandoned?

@sara-porter-iovation
Copy link

Apologies for the delay! We've undergone some team and tools changes over the last year+ that have impacted development. Fastest route to get issues to our team is via the Customer Success team. We recently released 5.4.1 to help with issues. Thank you for your patience!

@Amnell
Copy link
Author

Amnell commented Jul 26, 2023

@sara-porter-iovation I believe a better approach is if you and your developers actively utilise issues and pull-request features of GitHub. This is where you can access your client's developers as well as allowing us to reach you and your developers. Looking at issues as well as pull-requests we can clearly see that your customers are both asking questions as well as trying to help your team with pull requests. For example we have the PR #32 that adds support for SPM that is the standard package manager since 2019.

As for 5.4.1 it just states "Performance improvements.". Does it fix #35 and #36? We the customers don't know, and I'm not confident in implementing 5.4.1 if it risk introducing crashing as stated in #36. Is this something that your Customer Success team can address better than for example Ani Ortega or whatever developer is tasked to maintaining this library?

@sara-porter-iovation
Copy link

We appreciate the feedback! Our teams workflow is currently geared to respond to Customer Success tickets with a very limited amount of resources to keep track of Github and other feedback mechanisms. If the 5.4.0 and 5.4.1 releases have not resolved concerns, then please work with our CS folks so we can go through build tool configurations/installations, OS's, hardware (M1 vs Intel) and other scenarios to recreate the crashes, and identify and resolve. Thank you again for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests