Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcc_usdt.h no longer shared #2188

Closed
brendangregg opened this issue Feb 6, 2019 · 3 comments
Closed

bcc_usdt.h no longer shared #2188

brendangregg opened this issue Feb 6, 2019 · 3 comments

Comments

@brendangregg
Copy link
Member

This came with bcc, and is used by bpftrace, but no longer is shipped. bpftrace builds get:

/mnt/src/bpftrace/src/ast/irbuilderbpf.h:5:10: fatal error: bcc_usdt.h: No such file or directory
 #include "bcc_usdt.h"
          ^~~~~~~~~~~~

bpftrace/bpftrace#389

in bcc it's still in src/cc/CMakeLists.txt:

if(ENABLE_USDT)
  list(APPEND bcc_api_headers bcc_usdt.h)

But I don't get bcc_usdt.h in libbpfcc or libbpfcc-dev (version 5.0). Maybe that CMakeLists.txt file needs updating again to add it to libbpfcc-dev?

The symbols are in the library:

# objdump -tT /usr/lib/x86_64-linux-gnu/libbcc.so.0.5.0 | grep bcc_usdt
000000000232a810 g    DF .text	0000000000000100  Base        bcc_usdt_get_probe_argctype
000000000232a920 g    DF .text	00000000000000f2  Base        bcc_usdt_get_location
000000000232f1d0 g    DF .text	0000000000000e7d  Base        bcc_usdt_genargs
000000000232aa20 g    DF .text	0000000000000005  Base        bcc_usdt_foreach_uprobe
000000000232e8e0 g    DF .text	000000000000005f  Base        bcc_usdt_new_frompid
000000000232e530 g    DF .text	00000000000000e6  Base        bcc_usdt_new_frompath
[...]
@brendangregg
Copy link
Member Author

Oh, maybe we debugged this before and it was due to Ubuntu 18.04 having an older bcc? bpftrace/bpftrace#335

@mmarchini
Copy link
Member

Seems to be included on libbcc packages (at least on recent versions). Can we close this?

@yonghong-song
Copy link
Collaborator

Yes, let close this. 0.8 and 0.9 should have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants