fix incorrect arch register use for kprobe func with more parameters #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 12107c6 ("use correct arch register for the 4th param of x86_64 syscalls") tries to use proper syscall specific registers on x86_64 as its 4th param for syscall is different from non-syscall. Unfortunately, the implementation also uses syscall arch. register for non-syscall kernel functions, which is incorrect. This patch fixed the issue by using syscall arch registers only for syscalls. Reported-by: zhenwei pi <pizhenwei@bytedance.com> Fixes: 12107c6 ("use correct arch register for the 4th param of x86_64 syscalls") Signed-off-by: Yonghong Song <yhs@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 12107c6 ("use correct arch register for the
4th param of x86_64 syscalls") tries to use proper syscall
specific registers on x86_64 as its 4th param for syscall
is different from non-syscall. Unfortunately, the
implementation also uses syscall arch. register
for non-syscall kernel functions, which is incorrect.
This patch fixed the issue by using syscall arch
registers only for syscalls.
Reported-by: zhenwei pi pizhenwei@bytedance.com
Fixes: 12107c6 ("use correct arch register for the 4th param of x86_64 syscalls")
Signed-off-by: Yonghong Song yhs@fb.com