libbpf-tools: Fix cachestat with kernel 5.15 #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhengqi
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
@chenhengqi is this still a 'draft'? I think it's mergeable as-is |
|
It works on kernel 5.15, but still broken on recent 5.16-rc :( |
|
Works on 5.16.7 kernel. |
chenhengqi
force-pushed
the
fix-cachestat
branch
from
34ae11e
to
f4bdc26
Compare
chenhengqi
force-pushed
the
fix-cachestat
branch
2 times, most recently
from
c2affb4
to
f36fc10
Compare
The tool cachestat is broken on kernel 5.15 due to kernel function renaming. Fix the tool by detecting symbol existence. See iovisor#3687 and iovisor#3692. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
chenhengqi
force-pushed
the
fix-cachestat
branch
from
f36fc10
to
94745d1
Compare
|
@davemarchevsky Could you take a look at this again ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool cachestat is broken on kernel 5.15 due to kernel function
renaming. Fix the tool by detecting symbol existence. See #3687 and
#3692.
Signed-off-by: Hengqi Chen chenhengqi@outlook.com