Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile: a CPU profiler #620

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Add profile: a CPU profiler #620

merged 2 commits into from
Jul 22, 2016

Conversation

brendangregg
Copy link
Member

fixes #617

4ast
4ast reviewed Jul 20, 2016
View reviewed changes
tools/profile.py
#

# use perf_events to sample
class Perf(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why copy paste? can you change Perf object instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

@4ast
Copy link
Member

4ast commented Jul 21, 2016

nice! Looks great to me.

@4ast 4ast merged commit f4bf275 into iovisor:master Jul 22, 2016
@brendangregg brendangregg mentioned this pull request Jul 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPU profiling RFC
2 participants
@brendangregg @4ast