[cachetop] fix stats computation per processes. #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mpa = v.value | ||
| if mpa < 0: | ||
| mpa = 0 | ||
| mpa = max(0, mpa) |
There was a problem hiding this comment.
/facepalm. totally.... I only have 1 line right which was enough to visually look sane :s
The current logic was only initializing page accesses, mark dirty.. at the beginning of the method, preventing counters to be ever reset for each PIDs. Piggyback iovisor#615 (comment) Tested by running both tools manually.
chantra
force-pushed
the
fix_cachetop_logic
branch
from
78aff07
to
177f9be
Compare
palmtenor
pushed a commit
to palmtenor/bcc
that referenced
this pull request
Jul 31, 2016
The current logic was only initializing page accesses, mark dirty.. at the beginning of the method, preventing counters to be ever reset for each PIDs. Piggyback iovisor#615 (comment) Tested by running both tools manually.
chantra
added a commit
to chantra/bcc
that referenced
this pull request
Sep 16, 2016
The current logic was only initializing page accesses, mark dirty.. at the beginning of the method, preventing counters to be ever reset for each PIDs. Piggyback iovisor#615 (comment) Tested by running both tools manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic was only initializing page accesses, mark dirty.. at
the beginning of the method, preventing counters to be ever reset for
each PIDs.
Piggyback #615 (comment)
Tested by running both tools manually.