Improve error messages for kfunc #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbs
reviewed
Aug 4, 2020
src/btf.cpp
Outdated
| @@ -439,23 +440,37 @@ int BTF::resolve_args(const std::string &func, | |||
|
|
|||
| t = btf__type_by_id(btf, t->type); | |||
| if (!btf_is_func_proto(t)) | |||
| return -1; | |||
| { | |||
| throw std::runtime_error("not a function\n"); | |||
There was a problem hiding this comment.
Suggested change
| throw std::runtime_error("not a function\n"); | |
| throw std::runtime_error("not a function"); |
fbs
requested changes
Aug 4, 2020
Most of the errors for kfunc (non-existing or non-traceable function etc.) occur when resolving kfunc arguments. Instead of printing a generic "resolving kfunc arguments failed", print a better message that could help the user to identify the problem.
viktormalik
force-pushed
the
kfunc-error-messages
branch
from
c325fe3
to
f0cc28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the errors for kfunc (including, e.g., detecting a non-existing or a non-traceable function) occur when resolving kfunc arguments. This PR proposes to print more informative messages (instead of a generic "resolving kfunc arguments failed") that could help user to identify the problem.
Related to #841
Checklist
docs/reference_guide.mdCHANGELOG.md