Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Disable Lockdown section to indicate error may from snap #2001

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Update Disable Lockdown section to indicate error may from snap #2001

merged 1 commit into from
Sep 10, 2021

Conversation

haosdent
Copy link
Contributor

@haosdent haosdent commented Sep 9, 2021

Update Disable Lockdown section to indicate error may be from the snap installation way.

Checklist
  • Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

viktormalik
viktormalik reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is just a note, I'd suggest moving it to the end of the section.

INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
@haosdent
Copy link
Contributor Author

haosdent commented Sep 9, 2021

Thx @viktormalik !

viktormalik
viktormalik reviewed Sep 9, 2021
View reviewed changes
INSTALL.md Outdated Show resolved Hide resolved
viktormalik
viktormalik approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please squash the commits into one?

@haosdent @viktormalik
Update Disable Lockdown section to indicate error may from the snap…
b3ed778 
… installation way.

Co-authored-by: Viktor Malík <viktor.malik@gmail.com>
@haosdent
Copy link
Contributor Author

haosdent commented Sep 9, 2021

@viktormalik done, thank you!

@fbs fbs merged commit 00d4f4f into bpftrace:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktormalik viktormalik viktormalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haosdent @viktormalik @fbs