Handle enum values in tracepoint format defs #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktormalik
force-pushed
the
tp-format-enums
branch
2 times, most recently
from
ef5c74d
to
8bdd2cc
Compare
|
LGTM, but can we add a unit test for this? |
viktormalik
force-pushed
the
tp-format-enums
branch
from
8bdd2cc
to
4f4418e
Compare
Good idea, I extended an existing unit test for tracepoint parsing. |
danobi
approved these changes
May 31, 2022
It may happen that a tracepoint format definition contains enum values instead of constants for array sizes. If that happens, insert the enum value into bpftrace.btf_set_ to get the enum definition from BTF. This bug broke tools/bitesize.bt on 5.17.4-200.fc35.x86_64 kernel.
viktormalik
force-pushed
the
tp-format-enums
branch
from
4f4418e
to
f237952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that a tracepoint format definition contains enum values instead of constants for array sizes. Not sure if this is a kernel bug or a legit behaviour but it has happened at my system (5.17.4-200.fc35.x86_64 kernel):
breaking
tools/bitesize.bt(fails witherror: use of undeclared identifier 'TASK_COMM_LEN').This PR fixes the problem by inserting the enum value into
bpftrace.btf_set_to get the definition from BTF.Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md