Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds against libbfd(binutils) >=2.39 #2328

Merged
merged 1 commit into from Aug 16, 2022
Merged

Fix builds against libbfd(binutils) >=2.39 #2328

merged 1 commit into from Aug 16, 2022

Conversation

viktormalik
Copy link
Contributor

@viktormalik viktormalik commented Aug 16, 2022 •
edited

Binutils 2.39 changed signature of the init_disassemble_info function by adding an extra parameter for styled printf function. Let CMake detect which of the versions is present and call it appropriately.

Fixes #2324.

Checklist
  • Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

@viktormalik
Fix builds against libbfd(binutils) >=2.39
3be6e70 
Binutils 2.39 changed signature of the init_disassemble_info function by
adding an extra parameter for styled printf function. Let CMake detect
which of the versions is present and call it appropriately.
@viktormalik viktormalik mentioned this pull request Aug 16, 2022
Closed
@danobi danobi mentioned this pull request Aug 16, 2022
Closed
3 tasks
danobi
danobi approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@danobi danobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danobi danobi merged commit 0fba258 into bpftrace:master Aug 16, 2022
@viktormalik viktormalik deleted the libbfd-init-info-fix branch August 24, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danobi danobi danobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

building against binutils 2.39 libbfd fails
2 participants
@viktormalik @danobi