Add fentry/fexit aliases for kfunc/kretfunc #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to handle the listing of kfuncs e.g. |
danobi
reviewed
Nov 22, 2023
docs/reference_guide.md
Outdated
Comment on lines
60
to
61
| - [17. `kfunc`/`kretfunc` (alias: `fentry`/`fexit`): Kernel Functions Tracing](#17-kfunckretfunc-kernel-functions-tracing) | ||
| - [18. `kfunc`/`kretfunc` (alias: `fentry`/`fexit`): Kernel Functions Tracing Arguments](#18-kfunckretfunc-kernel-functions-tracing-arguments) |
There was a problem hiding this comment.
Maybe leave the alias out of the section titles. Cuz we don't do that for the u: and k: stuff either. Also the link seems to be broken
There was a problem hiding this comment.
I wanted to make them easier to find but I guess people can always search/find.
There was a problem hiding this comment.
Yeah, I'm hoping to keep the headers terse. Grep will find it anyways
docs/reference_guide.md
Outdated
Comment on lines
1790
to
1793
| kfunc[:module]:function | ||
| kretfunc[:module]:function | ||
| fentry[:module]:function | ||
| fexit[:module]:function |
There was a problem hiding this comment.
You mean like kfunc/fentry[:module]:function ?
There was a problem hiding this comment.
Oh sorry, I meant like:
kfunc[:module]:function
fentry[:module]:function
kretfunc[:module]:function
fexit[:module]:function
jordalgo
force-pushed
the
fentry-alias
branch
from
a192eb6
to
9091ce0
Compare
danobi
approved these changes
Nov 24, 2023
The 'kfunc' name was in bpftrace first and was "borrowed" by the kernel to now mean something completely different (yet related to bpf). New users going to look for fentry/fexit equivalents in bpftrace are going to be confused that they are called kfunc and kretfunc here. This change just adds fentry/fexit as aliases for kfunc/kretfunc.
jordalgo
force-pushed
the
fentry-alias
branch
from
9091ce0
to
78c43ac
Compare
ajor
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'kfunc' name was in bpftrace first and was "borrowed" by the kernel to now mean something completely different (yet related to bpf). New users going to look for fentry/fexit equivalents in bpftrace are going to be confused that they are called kfunc and kretfunc here. This change just adds fentry/fexit as aliases for kfunc/kretfunc.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md