Merge remote-tracking branch 'origin/master' into job-deadlines

iovisor · Sep 18, 2019 · 7029bba · 7029bba
2 parents 80cd6b8 + ccbe98a
commit 7029bba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ mv kubectl-trace /usr/local/bin/kubectl-trace
 **OSX**
 
 ```bash
-curl -Lo https://github.com/iovisor/kubectl-trace/releases/download/v0.1.0-rc.0/kubectl-trace_0.1.0-rc.0_linux_amd64.tar.gz
+curl -L -o kubectl-trace.tar.gz https://github.com/iovisor/kubectl-trace/releases/download/v0.1.0-rc.0/kubectl-trace_0.1.0-rc.0_darwin_amd64.tar.gz
 tar -xvf kubectl-trace.tar.gz
 mv kubectl-trace /usr/local/bin/kubectl-trace
 ```

diff --git a/pkg/cmd/get.go b/pkg/cmd/get.go
@@ -200,7 +200,7 @@ func jobsTablePrint(o io.Writer, jobs []tracejob.TraceJob) {
 
 // translateTimestampSince returns the elapsed time since timestamp in
 // human-readable approximation.
-func translateTimestampSince(timestamp metav1.Time) string {
+func translateTimestampSince(timestamp *metav1.Time) string {
 	if timestamp.IsZero() {
 		return "<unknown>"
 	}

diff --git a/pkg/tracejob/job.go b/pkg/tracejob/job.go
@@ -37,7 +37,7 @@ type TraceJob struct {
 	FetchHeaders        bool
 	Deadline            int64
 	DeadlineGracePeriod int64
-	StartTime           metav1.Time
+	StartTime           *metav1.Time
 	Status              TraceJobStatus
 }
 
@@ -133,7 +133,7 @@ func (t *TraceJobClient) GetJob(nf TraceJobFilter) ([]TraceJob, error) {
 			ID:        types.UID(id),
 			Namespace: j.Namespace,
 			Hostname:  hostname,
-			StartTime: *j.Status.StartTime,
+			StartTime: j.Status.StartTime,
 			Status:    jobStatus(j),
 		}
 		tjobs = append(tjobs, tj)