feat(init): support installing headers on generic linux distributions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
reviewed
Mar 11, 2019
leodido
approved these changes
Mar 11, 2019
fntlnz
changed the title
fntlnz
approved these changes
Mar 17, 2019
There was a problem hiding this comment.
LGTM 🥇 Good job as always @dalehamel ! Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leodido @fntlnz please take a look
This should enhance the
--fetch-headerscode path to work for any linux distribution, not just container OS.I've also optimized a bit, by deleting abundant non-header files that aren't needed, which speeds up the inter-device move pretty substantially. I also decided it would be prudent to keep track of the time spent in the major operations in the script.
I've tested the generic path by commenting out the container OS one, but please try it for yourself to be sure it's all working as expected.