Issue126 clang format license check #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gretton-dann
requested changes
Oct 15, 2022
There was a problem hiding this comment.
I would like to see a .editorconfig to go with the .clang-format file as that helps editors implement the 120 character column limit, and indentation rules (and new-lines at end of files).
There are some other technical details (see comments on bits of source) that I think need working out but I'm overall happy with the direction taken.
matt-gretton-dann
requested changes
Oct 17, 2022
Alan-Jowett
force-pushed
the
issue126-clang-format-license-check
branch
from
25f8af1
to
86860e6
Compare
matt-gretton-dann
requested changes
Oct 19, 2022
matt-gretton-dann
approved these changes
Oct 20, 2022
matt-gretton-dann
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Happy with this now. @Alan-Jowett: Do you mind doing the conflict resolution in the merge?
Alan-Jowett
force-pushed
the
issue126-clang-format-license-check
branch
from
67adb66
to
69cdb72
Compare
Add docs/Contributing.md Add .editorconfig Apply clang formatting to existing files Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Alan-Jowett
force-pushed
the
issue126-clang-format-license-check
branch
from
69cdb72
to
fde192f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Contributing.md guide to propose / document style guidelines.
Add scripts to check formatting and licensing at checkin.
Resolves: #126
Signed-off-by: Alan Jowett alanjo@microsoft.com