Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize R2 with data length #22

Closed
wants to merge 1 commit into from
Closed

initialize R2 with data length #22

wants to merge 1 commit into from

Conversation

ygrek
Copy link

@ygrek ygrek commented Nov 19, 2018

It is convenient to know data size immediately, without going through indirect structure. What do you think?

@ygrek
Copy link
Author

ygrek commented Nov 22, 2018

afaics the tests are failing because of smth unrelated :

======================================================================
ERROR: test_elf.test_datafiles('elf/wrong-version.data',)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/.local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/travis/build/iovisor/ubpf/test_framework/test_elf.py", line 176, in check_datafile
    elf = generate_elf(data['pyelf'])
  File "/home/travis/build/iovisor/ubpf/test_framework/test_elf.py", line 163, in generate_elf
    return serialize(parts)
  File "/home/travis/build/iovisor/ubpf/test_framework/test_elf.py", line 146, in serialize
    serializer = s.Elf_Ehdr.build
AttributeError: 'ELFStructs' object has no attribute 'Elf_Ehdr'

@pchaigno
Copy link
Collaborator

#24 should fix the tests.

Could you add a test case for this change?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 96.694% when pulling b7caed9 on ygrek:r2 into 10e0a45 on iovisor:master.

@pchaigno
Copy link
Collaborator

@ygrek Could you add a test for this change please? I won't merge without it. I can help write the test if necessary of course.

@ygrek
Copy link
Author

ygrek commented Feb 17, 2022

(merged)

@ygrek ygrek closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants