ubpf.h: Add <stdbool.h> to external header file #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 089f627 added the bool type to an external function but did not add the approriate header to define that type. This still allowed the library to be built because <stdbool.h> was included in the internal library source files. However it causes issues when linking to this library from other programs. Fixes iovisor#38
iomartin
added a commit
to Eideticom/eid-hermes-qemu
that referenced
this pull request
Oct 19, 2020
uBPF[1] is a userspace eBPF virtual machine, which includes an assembler, disassembler, interpreter and JIT compiler for x86-64. Because it is not part of the kernel, it can be used by userspace tools that need to operate on programs in the eBPF ISA. We need this to enable the hermes device model. There is currently an open issue on uBPF[2] that requires the inclusion of stdbool.h as well as ubpf.h. A PR has been opened[3], but has not yet been merged into upstream, so we add that header to our configure script. [1]: https://github.com/iovisor/ubpf [2]: iovisor/ubpf#38 [3]: iovisor/ubpf#39 Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
|
Thanks! |
niclashedam
pushed a commit
to niclashedam/eid-hermes-qemu
that referenced
this pull request
Feb 17, 2021
uBPF[1] is a userspace eBPF virtual machine, which includes an assembler, disassembler, interpreter and JIT compiler for x86-64. Because it is not part of the kernel, it can be used by userspace tools that need to operate on programs in the eBPF ISA. We need this to enable the hermes device model. There is currently an open issue on uBPF[2] that requires the inclusion of stdbool.h as well as ubpf.h. A PR has been opened[3], but has not yet been merged into upstream, so we add that header to our configure script. [1]: https://github.com/iovisor/ubpf [2]: iovisor/ubpf#38 [3]: iovisor/ubpf#39 Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 089f627 added the bool type to an external function but did not
add the approriate header to define that type. This still allowed the
library to be built because <stdbool.h> was included in the internal
library source files. However it causes issues when linking to this
library from other programs.
Fixes #38