Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimization build settings #504

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

hawkinsw
Copy link
Collaborator

@hawkinsw hawkinsw commented Jun 9, 2024

Default build settings were inadvertantly changed so that optimization was always disabled. This PR fixes that mistake and updates debug build configuration to guarantee that optimization is disabled.

Default build settings were inadvertantly changed so that optimization
was always disabled. This PR fixes that mistake and updates debug build
configuration to guarantee that optimization is disabled.

Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
@hawkinsw hawkinsw self-assigned this Jun 9, 2024
@hawkinsw hawkinsw requested a review from Alan-Jowett June 9, 2024 03:02
@coveralls
Copy link

Coverage Status

coverage: 81.346%. remained the same
when pulling d05cae8 on hawkinsw:fix_optimization_build_settings
into 5aabbca on iovisor:main.

@Alan-Jowett Alan-Jowett enabled auto-merge (squash) June 10, 2024 14:52
@Alan-Jowett Alan-Jowett merged commit 92c5a50 into iovisor:main Jun 10, 2024
38 checks passed
@coveralls
Copy link

Coverage Status

coverage: 81.346%. remained the same
when pulling cf4227d on hawkinsw:fix_optimization_build_settings
into 7e1d3cb on iovisor:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants