Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit overriding maximum stack size #67

Merged
merged 2 commits into from
May 14, 2021
Merged

Conversation

Alan-Jowett
Copy link
Collaborator

@Alan-Jowett Alan-Jowett commented May 12, 2021

Permit overriding maximum stack size at compile time.

Resolves: #65

Signed-off-by: Alan Jowett alan.jowett@microsoft.com

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
@coveralls
Copy link

coveralls commented May 12, 2021

Coverage Status

Coverage remained the same at 95.541% when pulling ebd802c on Alan-Jowett:issue65 into 6492b7a on iovisor:master.

@jpsamaroo
Copy link

jpsamaroo commented May 12, 2021

I think you meant this resolves #65, which it doesn't seem to, since you keep the default stack size at 128. Maybe bump it to 512 here as well?

@Alan-Jowett
Copy link
Collaborator Author

The intent is to leave the default at 128 (not sure why that value was picked, but don't want to break anyone's code that depends on it).

By wrapping this in a #if !defined(STACK_SIZE) I can override it at compile time.

@rlane
Copy link
Collaborator

rlane commented May 13, 2021

Could you move the #define to ubpf.h, and add a "UBPF_" prefix to it? That way the config option is better documented.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
@Alan-Jowett
Copy link
Collaborator Author

Great idea, moved both limits to ubpf.h and added a note that they are defaults values.

@rlane rlane merged commit c7c019c into iovisor:master May 14, 2021
@Alan-Jowett Alan-Jowett deleted the issue65 branch June 22, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uBPF should support the standard 512 byte stack size
4 participants