New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeated read on failed websocket connection #4

Merged

iowar merged 1 commit into iowar:master from js0n:bugfix/ws_repeated_read

Feb 18, 2020

Contributor

js0n commented Feb 10, 2020

Running into this issue:

Repeated read attempts on a failed websocket connection result in an unrecoverable fatal panic, similarly documented here: gorilla/websocket#476.

This patch bubbles the error up and re-establishes the websocket connection before subsequent attempts at ws.readMessage().


          avoid repeated read on failed websocket connection

e217a2b

js0n requested a review from iowar

February 10, 2020 17:30

iowar merged commit e2645f3 into iowar:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment