Add order_by, limit and offset in find query #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g this to test the version with limit & order-by params in later PRs.
…nd to IMHO make it a little clearer, allowing more type declarations, even though it's still not perfect. docs not added yet, is an API proposal for consideration. have been using this a couple of weeks in production happily.
test_find_multiple. I made a bug earlier when touched find(), am usin…
TheHelias
force-pushed
the
feature/sort-limit-offset-in-find
branch
from
64045de
to
f0cb5dc
Compare
lietu
reviewed
Feb 26, 2024
lietu
reviewed
Feb 26, 2024
feat: support limit, sorting and offset in find fix: attend to comments fix: add new params to docstring improve docstring fix Co-Authored-By: Janne Enberg <janne.enberg@lietu.net>
TheHelias
force-pushed
the
feature/sort-limit-offset-in-find
branch
from
f0cb5dc
to
1ae57f5
Compare
lietu
approved these changes
Feb 26, 2024
This was referenced Feb 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add order_by, limit and offset as options in find query parameters
Updated urllib3 for fix vulnerabilities