Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization of USPTO document numbers for granted patents #13

Closed
amotl opened this issue Feb 21, 2019 · 3 comments
Closed

Fix normalization of USPTO document numbers for granted patents #13

amotl opened this issue Feb 21, 2019 · 3 comments

Comments

@amotl
Copy link
Member

amotl commented Feb 21, 2019

@aghster spotted an issue with normalizing numbers for USPTO appropriately:

I think you will have to pad document numbers for granted patents with leading zeros to ensure that the length is 8 for patents preceeding US 10,000,000 B2. However, normalize_patent_us() does not seem to do this.

See also [the kind of reference implementation] PatentsViewApp.openPDF().

@amotl
Copy link
Member Author

amotl commented Feb 21, 2019

Dear @aghster,

thank you so much for watching this closely enough so you have been able to spot this. Shortly after deploying this release, we already recognized spurious exceptions like ValueError: US document number "US2548918" has unexpected length.

You are right, https://github.com/ip-tools/ip-navigator/blob/5f4ec85edbdd6090003aaf87962384693c3ae3ec/patzilla/util/numbers/normalize.py#L390 apparently does not account for padding to 8 digits yet - happy to see you linked to the reference implementation already.

We will try to improve that, thanks again.

Cheers,
Andreas.

@amotl
Copy link
Member Author

amotl commented Mar 5, 2019

@aghster: Should be fixed through f8c4d50 and will become part of the next release.

@amotl
Copy link
Member Author

amotl commented Mar 5, 2019

We can confirm this should be fixed now. You might want to partly validate the outcome by having a look at the corresponding doctests:

Thanks again for spotting this, @aghster!

@amotl amotl closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant