Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ros node for direct sdax communication #21

Merged

Conversation

benmaidel
Copy link
Member

This node can be run directly on raspberry if ros is installed on it. Raspberry also have to be connected to ros network.

Copy link
Member

@floweisshardt floweisshardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work fine. I'll fixed the two minor comments and then merge

@@ -0,0 +1,15 @@
<?xml version="1.0"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this launch file, it's in cob_bringup (see ipa320/cob_robots#753). please remove

@@ -0,0 +1,509 @@
/*
* Copyright 2017 Fraunhofer Institute for Manufacturing Engineering and Automation (IPA)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be
Copyright 2017 Mojin Robotics

@floweisshardt floweisshardt merged commit aa5dfc1 into ipa320:indigo_dev Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants