Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and conversion to package format 2 #54

Merged
merged 1 commit into from
Nov 24, 2015

Conversation

ipa-rmb
Copy link
Contributor

@ipa-rmb ipa-rmb commented Nov 17, 2015

No description provided.

@floweisshardt
Copy link
Member

FR: OK
@ipa-fxm please do a CR

@@ -12,16 +13,13 @@
<author email="goa@ipa.fhg.de">Georg Arbeiter</author>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change maintainer?

@fmessmer
Copy link
Member

This PR only affects package.xml files.... did you check whether the CMakeLists.txt files (especially the find_package and catkin_package tags) have to be adjusted accordingly? see ipa320/care-o-bot#7

@fmessmer
Copy link
Member

Also, when converting to package-format 2, we agreed to consequently use:
add_dependencies(TARGET ${${PROJECT_NAME}_EXPORTED_TARGETS}) in case you generate messages within this package and add_dependencies(TARGET ${catkin_EXPORTED_TARGETS}) in case this package includes any package that generates messages/services/actions....

(use add_dependencies(TARGET ${${PROJECT_NAME}_EXPORTED_TARGETS} ${catkin_EXPORTED_TARGETS}) in case both applies!)

Do not use any *_generate_messages_cpp or *_gen_cpp or alike.

floweisshardt pushed a commit to floweisshardt/cob_perception_common that referenced this pull request Nov 24, 2015
@floweisshardt floweisshardt mentioned this pull request Nov 24, 2015
@fmessmer fmessmer merged commit 1f6a6d7 into ipa320:indigo_dev Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants