Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for a warning #82

Merged
merged 1 commit into from
Aug 2, 2017
Merged

bugfix for a warning #82

merged 1 commit into from
Aug 2, 2017

Conversation

ipa-rmb
Copy link
Contributor

@ipa-rmb ipa-rmb commented Aug 1, 2017

No description provided.

@ipa-rmb ipa-rmb requested a review from fmessmer August 1, 2017 16:07
@fmessmer
Copy link
Member

fmessmer commented Aug 1, 2017

@ipa-rmb please post the warning output to the PR description

@ipa-rmb
Copy link
Contributor Author

ipa-rmb commented Aug 2, 2017

Warning:
08:35:48 [ 50%] Building CXX object CMakeFiles/object_detection_visualizer.dir/ros/src/object_detection_visualizer_node.cpp.o
08:35:48 :0:15: warning: missing whitespace after the macro name

ipa-fmw suspected it might originate from here:
#if CV_MAJOR_VERSION == 2
// do opencv 2 code
#include <opencv/highgui.h>
#elif CV_MAJOR_VERSION == 3
// do opencv 3 code
#include <opencv2/highgui.hpp>
#endif

fmessmer
fmessmer approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it solves the warning...
seems not to harm the dual-distro compatibility...

@ipa-rmb ipa-rmb merged commit 972391e into ipa320:indigo_dev Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ipa-rmb @fmessmer