[cob4-2] Sensorring with asus camera #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # camera coordinate frame (image coordinate system with x-axis to the right, y-axis downwards, z-axis into viewing direction of the camera) | ||
| # string | ||
| camera_frame: cam3d_rgb_optical_frame |
There was a problem hiding this comment.
this parameter looks wrong, but I get an error if I set it as sensorring_cam3d_frame...
There was a problem hiding this comment.
what is the error? can you copy-paste it?
|
Merge together with: |
| <group> | ||
| <machine name="cob4-2-s1" address="$(arg cob4-2-s1)" env-loader="$(find cob_bringup)/env.sh" default="true" timeout="30"/> | ||
| <!-- pc monitor --> | ||
| <include file="$(find cob_bringup)/tools/pc_monitor.launch" > |
There was a problem hiding this comment.
we probably have to update diagnostics configuration to include cob4-2-s1 pc in the PC diagnostics.
There was a problem hiding this comment.
Yes, you are right. I updated the diagnostics configuration
|
LGTM |
floweisshardt
pushed a commit
that referenced
this pull request
Nov 10, 2015
[cob4-2] Sensorring with asus camera
|
Still, I would like to know what the error was! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.