Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup cob4-7 #728

Merged
merged 2 commits into from
Oct 19, 2017
Merged

setup cob4-7 #728

merged 2 commits into from
Oct 19, 2017

Conversation

ipa-nhg
Copy link
Member

@ipa-nhg ipa-nhg commented Oct 11, 2017

  • added arms configuration
  • commented head and sensorring

@ipa-nhg
Copy link
Member Author

ipa-nhg commented Oct 11, 2017

this PR requires ipa320/cob_calibration_data#142
@cagbal @ipa-rmb FYI

<xacro:include filename="$(find cob_description)/urdf/cob4_arm/cob4_arm.urdf.xacro" />

<!-- hand -->
<xacro:include filename="$(find cob_description)/urdf/cob4_gripper/gripper.urdf.xacro" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grippers are not added to the urdf...and also not part of the robot.xml...is that intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the motors of the hands are missed/broken... I am not sure if the hands will be replaced, still to be clarified...

@@ -66,6 +72,14 @@
<origin xyz="${head_cam_x} ${head_cam_y} ${head_cam_z}" rpy="${head_cam_roll} ${head_cam_pitch} ${head_cam_yaw}" />
</xacro:usb_cam>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as head is disabled in robot.xml, you might need to set the dof's to false...otherwise it will collapse in simulation
...same for sensorring!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again components broken, to be clarified.. but if the sim will not work I can temporally update the URDF

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
for explanation:
in simulation the head will hang loose because there is no controller because they are not loaded because the head part is commented in the robot.xml
setting the dof's to false makes the joints fixed instead of revolute and thus no controllers are needed

@fmessmer
Copy link
Member

@ipa-rmb @ipa-bfb @cagbal
please review - it won't get merged otherwise

@ipa-jba @ipa-fez

Copy link
Contributor

@ipa-rmb ipa-rmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks fine, but what can I tell with my limited arm/hardware/config knowledge and experience. Maybe @ipa-bfb can give a better assessment.

By the way, if the robot is for 324 then I would expect that every component works (is this the same robot as referred to in Johannes' mail?) - or is there some other agreement by our bosses?

@cagbal
Copy link
Member

cagbal commented Oct 18, 2017

I could not understand that Johannes mentioned a cob4-2 robot, but this is about cob4-7. Is this the robot which will stay with us?

@fmessmer
Copy link
Member

you need to get to know your robots 😉

@fmessmer fmessmer merged commit 1d48718 into ipa320:indigo_dev Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants