Noetic / MoveIt-master compatibility #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wxmerkt
commented
Jun 22, 2020
wxmerkt
commented
- Builds with lots of warnings
- Tests fail and need to be upgraded/made compatible
…'s missing as not declared as a dependency)
…t both Python2 and Python3
…MoveIt The latest version of MoveIt correctly distinguishes visual and collision links. For setting up the unittests, we incorrectly only used the visual-tag. Formerly, MoveIt interpreted the visual tag also as a collision tag if no collision tag was specified. This has now been changed. As a result, we need to fix our URDFs that made incorrect use of that upstream bug.
…sions of googletest
…m, (l/r)_hand_force_torque These were visual only so in Melodic and older interpreted as collision links but in Noetic and newer (or MoveIt master in general) only as visual links.
…es to dynamics solver package to resolve circular dependency
…itialiser, deactivate Jacobian test Was broken before...
…st_depend on CollisionSceneFCL
|
Issues
======
+ Solved 3
- Added 1
Clones added
============
- exotations/exotica_core_task_maps/test/test_maps.cpp 14
See the complete overview on Codacy |
wxmerkt
commented
Jun 24, 2020
| def test_unknown_initializer_types(self): | ||
| output = None | ||
| if os.environ['ROS_PYTHON_VERSION'] == '2': | ||
| output = subprocess.check_output( |
There was a problem hiding this comment.
Codacy found an issue: subprocess call - check for execution of untrusted input.
wxmerkt
changed the title
VladimirIvan
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.