Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/adress/address #102

Merged
merged 1 commit into from
Aug 20, 2018
Merged

s/adress/address #102

merged 1 commit into from
Aug 20, 2018

Conversation

pedro-nonfree
Copy link
Contributor

@pedro-nonfree pedro-nonfree commented Aug 19, 2018 •
edited
Loading

fix typos

Extra: and in 0.8.3 this code is not available. when would be? Thanks

Wanted to use

IPAdress::valid_ipv4_subnet?

@pedro-nonfree
s/adress/address
4222321 
fix typos
smortex
smortex approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Oh my… style is not so good in this file, but it's beyond the scope of this PR.

@smortex
Copy link
Contributor

smortex commented Aug 20, 2018

Thanks! Unfortunately, there is no ETA for a new release of this gem. A first step would be to re-gain access to the gem on rubygem to the project's members, but I have not looked into this yet and it is currently quite low priority 😞 .

@smortex smortex merged commit a8eb06d into ipaddress-gem:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pedro-nonfree @smortex