Add IPv4 subnet validation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please excuse me, I'm not that good with IPv6 netmasking, therefore I did't implement it. |
|
Hello, this is an old PR! Now, GitHub can allows maintainers to add commits into your branch, this would allow us to add the corresponding IPv6 code. Can you please enable this feature (on the PR page, at the bottom of the right column, under the participants list, check Allow edits from maintainers. )? Thanks! |
smortex
requested changes
Aug 30, 2017
|
Hi @smortex, I have got it enabled. |
smortex
force-pushed
the
ipv4-subnet-validation
branch
from
0d16f93
to
81e192e
Compare
smortex
approved these changes
Sep 1, 2017
|
Dear @paudam, I rebased your changes on top of master and added a commit to add similar feature for IPv6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can create an ip with a netmask using
IPAddress.new "#{ip}/#{mask}", I would suggest thatIPAddress.valid? "#{ip}/#{mask}"should also validate it.