Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup suggestion: rename syncreg_v.dep to ipbus_syncreg_v.dep #141

Closed
jhegeman opened this issue Dec 15, 2019 · 2 comments
Closed

Cleanup suggestion: rename syncreg_v.dep to ipbus_syncreg_v.dep #141

jhegeman opened this issue Dec 15, 2019 · 2 comments
Milestone

Comments

@jhegeman
Copy link
Contributor

Hi,

In my opinion it would be nice(r) if the dep files had the same base name as the corresponding VHDL files. This is already the case for most of the existing dep files for the IPBus slaves, except for the one corresponding to ipbus_syncreg_v.vhdl, which is called simply syncreg_v.dep.

NOTE: This dep file is already included in several places, of course. In order to make the transition smoother (?) one could rename the file and add a symlink with the original name, maybe?

Cheers,
Jeroen

@jhegeman
Copy link
Contributor Author

Maybe, at the same time, one could rename the files syncreg_{r,w}.vhd to ipbus_syncreg_{r,w}.vhd.

@alessandrothea
Copy link
Collaborator

Well spotted, thanks!
The dep file should (and will eventually) be renamed to match the dep file. The only slight hiccup is that this change will break almost every existing ipbus-based design, but such is life.

Regarding syncreg_{r,w}.vhd, not necessarily. Those 2 entities are not ipbus specific and that is why they don't have the ipbus_ prefix at the moment. This might change in the future, as we're discussing how to handle these cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants