New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node tree builder does not use uppercase values for 'permission', but does not throw #146
Comments
tswilliams
added a commit
that referenced
this issue
Jan 3, 2020
tswilliams
added a commit
that referenced
this issue
Jan 3, 2020
…ues used in 'permission' attribute. Fixes #146
tswilliams
added a commit
that referenced
this issue
Jan 3, 2020
tswilliams
added a commit
that referenced
this issue
Jan 3, 2020
…xceptions when invalid value used for attributes. See #146
tswilliams
added a commit
that referenced
this issue
Jan 3, 2020
tswilliams
added a commit
that referenced
this issue
Jan 3, 2020
tswilliams
added a commit
that referenced
this issue
Jan 4, 2020
tswilliams
added a commit
that referenced
this issue
Jan 4, 2020
tswilliams
added a commit
that referenced
this issue
Jan 4, 2020
…xceptions when invalid value used for attributes. See #146
tswilliams
added a commit
that referenced
this issue
Jan 4, 2020
tswilliams
added a commit
that referenced
this issue
Jan 4, 2020
tswilliams
added a commit
that referenced
this issue
Jan 5, 2020
In fixing this issue, I realised that exceptions were also not being thrown for some invalid values of the |
jhegeman
pushed a commit
to jhegeman/ipbus-software
that referenced
this issue
Dec 6, 2021
Create depfile for ipbus_ctrl.vhd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If uppercase values are used for the
permission
attribute in the address table, then the node tree builder ignores these values and leaves the permission asREADWRITE
, but does not throw an exception. The same thing happens for completely invalid values.Example address tables illustrating this bug:
The node tree builder should be updated so that if the permissions attribute contains any invalid/unused characters, an exception is thrown.
The text was updated successfully, but these errors were encountered: