Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node tree builder does not use uppercase values for 'permission', but does not throw #146

Closed
tswilliams opened this issue Jul 9, 2019 · 1 comment
Assignees
Labels

Comments

@tswilliams
Copy link
Collaborator

If uppercase values are used for the permission attribute in the address table, then the node tree builder ignores these values and leaves the permission as READWRITE, but does not throw an exception. The same thing happens for completely invalid values.

Example address tables illustrating this bug:

<node fwinfo="endpoint;width=11">
  <node id="stat" address="0x0" permission="W" >
    <node id="mmcm_locked" mask="0x1"/>
    <node id="ready" mask="0x2"/>
  </node>
</node>
<node fwinfo="endpoint;width=11">
  <node id="stat" address="0x0" permission="bob" >
    <node id="mmcm_locked" mask="0x1"/>
    <node id="ready" mask="0x2"/>
  </node>
</node>

The node tree builder should be updated so that if the permissions attribute contains any invalid/unused characters, an exception is thrown.

@tswilliams tswilliams added the bug label Jul 9, 2019
@tswilliams tswilliams self-assigned this Jul 9, 2019
tswilliams added a commit that referenced this issue Jan 3, 2020
tswilliams added a commit that referenced this issue Jan 3, 2020
…xceptions when invalid value used for attributes. See #146
tswilliams added a commit that referenced this issue Jan 4, 2020
…xceptions when invalid value used for attributes. See #146
@tswilliams
Copy link
Collaborator Author

In fixing this issue, I realised that exceptions were also not being thrown for some invalid values of the id, mode, address, mask and size attributes. These additional omissions have been resolved along with the original subject of this ticket (invalid values for the permission attribute) in pull request #171.

@tswilliams tswilliams added this to the v2.7.0 release milestone Jan 18, 2020
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant