Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DummyHardware::SetEndpoint() became private ? #149

Closed
sly74fr opened this issue Sep 11, 2019 · 4 comments · Fixed by #156
Closed

DummyHardware::SetEndpoint() became private ? #149

sly74fr opened this issue Sep 11, 2019 · 4 comments · Fixed by #156

Comments

@sly74fr
Copy link

sly74fr commented Sep 11, 2019

Dear IPbus team,

First thank you very much for all your great work on IPbus !

I rely on UDPDummyHardware to create an hardware mockup of the board we develop.
I used SetEndpoint() for my mockup to reply specific values for identified register addresses.
But now I can't anymore as this method became private meanwhile.

Maybe there is another way around this ?
Otherwise how would you recommend doing this kind of custom dummy hardware ?
I would love being able to load some address:value tables to simulate my board easily :)
What do you think ?

Best regards,
Sly

PS: Please find my source code that use SetEndpoint() for further insights.
dummy_ldpb_board.cpp.zip

@tswilliams
Copy link
Collaborator

Hi,

Beyond using the SetEndpoint method there isn't any other way to accomplish what you want to do with the current API of the dummy hardware classes. Given that, I'll make relax that method to being protected again, and create a new patch release with that change in the next few weeks.

In the longer run, it might be wise for us to restructure the dummy hardware classes to enhance the support for this kind of use case. However, given the demands of other projects on my time over the next month, I won't be able to do such restructuring before the next patch release.

Cheers,
Tom

@sly74fr
Copy link
Author

sly74fr commented Sep 25, 2019

Hi
First thank you for the relaxing interim solution.
On the long term side of things, I remain at your disposal to further discuss it.
Cheers,

@tswilliams
Copy link
Collaborator

Hi @sly74fr

This fix has now been included in the version 2.6.5 release.

Cheers,
Tom

@sly74fr
Copy link
Author

sly74fr commented Nov 14, 2019

Thank you very much Tom,
Will keep you updated once deployed at CERN !

@tswilliams tswilliams added this to the v2.6.5 release milestone Jan 18, 2020
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
Slaves: Add new depfiles, and a few quick cleanup tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants