New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor performance improvements in clients #165
Milestone
Comments
tswilliams
pushed a commit
that referenced
this issue
Dec 1, 2019
tswilliams
added a commit
that referenced
this issue
Dec 1, 2019
tswilliams
pushed a commit
that referenced
this issue
Dec 1, 2019
tswilliams
added a commit
that referenced
this issue
Dec 1, 2019
tswilliams
added a commit
that referenced
this issue
Dec 1, 2019
This was referenced Dec 1, 2019
All done (merged into both |
jhegeman
pushed a commit
to jhegeman/ipbus-software
that referenced
this issue
Dec 6, 2021
This should fix IPbus issue ipbus#164.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Whilst debugging some uHAL-based software, Andy spotted a couple of minor changes that could improve the performance (and/or reduce CPU usage) of existing clients. In particular:
ClientInterface::uri()
method currently constructs a new string each time it is called. This method is used in various log messages, with the string-construction penalty incurred whether or not the log message is printed. So, theClientInterface::uri()
method should be updated to return a const reference to a cached URI string.PCIe::File
class, there's a bug in the buffer creation code meaning that as opposed to the intention of thecreateBuffer
method, the buffer is recreated for each transfer.The text was updated successfully, but these errors were encountered: