Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor performance improvements in clients #165

Closed
tswilliams opened this issue Dec 1, 2019 · 1 comment
Closed

Minor performance improvements in clients #165

tswilliams opened this issue Dec 1, 2019 · 1 comment

Comments

@tswilliams
Copy link
Collaborator

Whilst debugging some uHAL-based software, Andy spotted a couple of minor changes that could improve the performance (and/or reduce CPU usage) of existing clients. In particular:

  • The ClientInterface::uri() method currently constructs a new string each time it is called. This method is used in various log messages, with the string-construction penalty incurred whether or not the log message is printed. So, the ClientInterface::uri() method should be updated to return a const reference to a cached URI string.
  • In the PCIe::File class, there's a bug in the buffer creation code meaning that as opposed to the intention of the createBuffer method, the buffer is recreated for each transfer.
@tswilliams
Copy link
Collaborator Author

All done (merged into both master and release_2_6, the v2.6.x release branch). Closing.

@tswilliams tswilliams added this to the v2.6.6 release milestone Jan 18, 2020
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant