Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings: Add ConnectionManager methods for using externally-provided clients #186

Closed
tswilliams opened this issue Mar 17, 2020 · 1 comment
Closed

Python bindings: Add ConnectionManager methods for using externally-provided clients #186

tswilliams opened this issue Mar 17, 2020 · 1 comment
Labels
bug
Milestone
v2.7.3 release

Comments

@tswilliams
Copy link
Collaborator

As described in title; pull request #174 added new ConnectionManager::getDevice methods in C++, but not the corresponding Python bindings.
@tswilliams tswilliams added the bug label Mar 17, 2020
alessandrothea added a commit that referenced this issue Mar 17, 2020
@alessandrothea
Adding missing bindings and converters. See #186
e72779a
alessandrothea added a commit that referenced this issue Mar 18, 2020
@alessandrothea
Removed explcit std::vector from uint32_t list converter.
929609d 
See #186
alessandrothea added a commit that referenced this issue Mar 19, 2020
@alessandrothea
Adding missing bindings and converters. See #186
5268342
alessandrothea added a commit that referenced this issue Mar 19, 2020
@alessandrothea
Removed explcit std::vector from uint32_t list converter.
e5c6802 
See #186
tswilliams added a commit that referenced this issue Mar 19, 2020
@tswilliams
Add Python unit tests for newly-bound methods. See #186
43ab79c
@tswilliams tswilliams added this to the v2.7.3 release milestone Mar 21, 2020
@tswilliams
Copy link
Collaborator Author

All done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.7.3 release
Development

No branches or pull requests
1 participant
@tswilliams