Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node size attribute silently ignored without mode attribute #194

Closed
tswilliams opened this issue May 4, 2020 · 0 comments · Fixed by #196
Closed

Node size attribute silently ignored without mode attribute #194

tswilliams opened this issue May 4, 2020 · 0 comments · Fixed by #196
Assignees

Comments

@tswilliams
Copy link
Collaborator

In an address table, if the size attribute is specified without a mode attribute, the value of the size attribute is not used (the node is interpreted as a single-word node of size 1), and uHAL does not throw an exception or issue any warning.

For example:

<node>
  <node id='regA' address='0x0' />
  <node id='regB' address='0x1' size='blah'/>
  <node id='ram1' address='0x100' mode='block' size='256' />
  <node id='ram2' address='0x210' mode='block' size='16' />
  <node id='aPort' address='0x300' mode='port' size='1024' />
</node>

(Here, the offending node is regB.)

Really, uHAL should throw an exception if any node has a size attribute but no mode attribute, since the attribute's value is unused and silently ignoring it may confuse users. However, to give people time to correct any address tables for a few releases, the code should first be updated to just issue a warning message that states that offending address tables should be fixed.

@tswilliams tswilliams self-assigned this May 12, 2020
@tswilliams tswilliams added this to the v2.7.4 release milestone May 12, 2020
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
Testing a licence check candidate for `test-run-sim.sh`
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant