Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uHAL source code cleanup (end of 2017) #72

Closed
tswilliams opened this issue Nov 15, 2017 · 0 comments
Closed

uHAL source code cleanup (end of 2017) #72

tswilliams opened this issue Nov 15, 2017 · 0 comments
Assignees
@tswilliams
Labels
task
Milestone
v2.6.0 release

Comments

@tswilliams
Copy link
Collaborator

The uHAL C++ source code could benefit from some cleanup, including (but not necessarily limited to):

  • Remove code disabled by RUN_ASIO_MULTITHREADED and DISABLE_PACKET_COUNTER_HACK macros, and hence remove need for specifying these in compiler flags
  • Move implementations of template client classes into cpp files
  • Review code that leads to warnings in latest versions of gcc and/or clang
@tswilliams tswilliams added this to the v2.6.0 release milestone Nov 15, 2017
@tswilliams tswilliams self-assigned this Nov 15, 2017
tswilliams added a commit that referenced this issue Nov 26, 2017
@tswilliams
uHAL : Simplify way in which background commands are killed in test s…
717acd7 
…cript; also solves spurious errors on ubuntu; refs #72
@tswilliams tswilliams mentioned this issue Nov 26, 2017
Merged
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Remove IPbus client template parameter 'BigEndianHack…
187c15f 
…', since no longer used; refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Update IPbus clients so that 'max packet size' comes …
6c94aea 
…from member function rather than template parameter; refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Move implementation of templated client classes from …
225ec8e 
…hxx to cpp files; refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Move implementation of templated 'IPbusInspector' and…
8c2e224 
… 'DummyHardware' classes from hxx to cpp files; refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Remove RUN_ASIO_MULTITHREADED macro (keeping function…
5203ed9 
…ality from that macro being defined); refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Split 'Utilities.hpp' and 'Utilities.cpp' into 3 head…
4fec6cc 
…er files and 3 cpp files; refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Clean up include statements (remove unneccessary ones…
4304dcc 
… etc); refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Clean up include statements (remove unneccessary ones…
3fb857e 
… etc) - part 2; refs issue #72
tswilliams added a commit that referenced this issue Dec 6, 2017
@tswilliams
uHAL clean up : Start reorganising heirachy of uHAL client exceptions…
b473a03 
…; refs issue #72
@tswilliams tswilliams mentioned this issue Dec 7, 2017
Merged
tswilliams added a commit that referenced this issue Jan 11, 2018
@tswilliams
uHAL : Re-add 'uhal/Utilities.hpp' header file with deprecation messa…
158317e 
…ge, for backward compatibility for users that directly include that file; refs #72
@tswilliams tswilliams mentioned this issue Jan 11, 2018
Merged
tswilliams added a commit that referenced this issue Jan 24, 2018
@tswilliams
uHAL : Fix 'hang on exit' bug (due to unkilled background processes) …
e6d0712 
…in uhal_test_suite.py; refs #72
tswilliams added a commit that referenced this issue Jan 24, 2018
@tswilliams
uHAL : Remove unneccessary use of 'sudo' with controlhub commands in …
6f189f4 
…test suite; refs #72
tswilliams added a commit that referenced this issue Jan 24, 2018
@tswilliams
uHAL : Change unneccessarily-public methods of client classes to priv…
db97862 
…ate; refs #72
tswilliams added a commit that referenced this issue Jan 26, 2018
@tswilliams
uHAL : Change unneccessarily-public methods of client classes to priv…
5791231 
…ate; refs #72
tswilliams added a commit that referenced this issue Jan 28, 2018
@tswilliams
uHAL : Add missing includes, and purge unneccessary ones (using iwyu)…
bcd61d2 
…; refs #72
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
@dmnewbold @tswilliams
Adding variable aux clock frequency; refs ipbus#72
e559d03
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
@dmnewbold @tswilliams
Adding variable aux clock frequency; refs ipbus#72
3a40ce0
jhegeman pushed a commit to jhegeman/ipbus-software that referenced this issue Dec 6, 2021
@dmnewbold @tswilliams
Fixing VHDL time problems; refs ipbus#72
6bbf705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswilliams tswilliams

Labels
task
Projects
None yet
Milestone
v2.6.0 release
Development

No branches or pull requests
1 participant
@tswilliams