Fix https://github.com/ipeaGIT/r5r/issues/327

[luyuliu]

A simple fix.

[luyuliu]

I just tested this on detailed_itineraries(). I do not know if other functions would also use tryRunProcess to output csv though.

[rafapereirabr]

Hi @luyuliu . Thanks so much for opening this PR. I believe other functions in r5r also use tryRunProcess, so it would be necessary to check to what extent the code you edited would also affect other functions. Perhaps this is something @mvpsaraiva could have a look at ?

[luyuliu]

I did a quick test on other function (travel_time_matrix) with the parameter output_dir. It seems to be working, but the file name would be like from_xxx_xxx, with the second id being the same as the origin id. It doesn't seem to break the function, so it can be a temporary solution.

The best practice would be write function specific condition clause inside the tryRunProcess function based on the function that calls it. Or, it would be even better to have a dedicated output function to output csv.

[mvpsaraiva]

thanks @luyuliu. I'll merge this PR and fix the file names for the travel time matrices functions following your suggestion.

[rafapereirabr]

@luyuliu , thanks again for fixing this issue. We'll be adding you as a contributor to r5r if that's ok with you

[luyuliu]

Thanks. I’m glad to be listed as a contributor.