improve code coverage

ipeaGIT · Jun 15, 2023 · cd20740 · cd20740
1 parent 3ff5f41
commit cd20740
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/R/internal_fun.R b/R/internal_fun.R
@@ -144,7 +144,7 @@ simulate_border_config <- function(sf_object, nbc, output='vector', bootstrap_bo
   if( isFALSE(bootstrap_border) ) { positions <- candidate_positions; nbc <- length(candidate_positions) }
   if( isTRUE(bootstrap_border) ) { positions <- sample_positions(nbc = nbc, candidate_positions = candidate_positions) }
 
-  if (output == 'spatial') {
+  if (output == 'spatial') { # nocov start
     # number of jobs per cell
     jobs_per_cell <- 1 / nbc
 
@@ -155,7 +155,7 @@ simulate_border_config <- function(sf_object, nbc, output='vector', bootstrap_bo
     sf_object$nbc <- nbc
 
     return(sf_object)
-  }
+  } # nocov end
 
   if (output == 'vector') {
     # with all activities equally concentraded in 'positions'

diff --git a/R/uci.R b/R/uci.R
@@ -220,7 +220,7 @@ uci <- function(sf_object,
                                             distance = distance_border)
     }
     # parallel
-    else if (isTRUE(parallel)) {
+    if (isTRUE(parallel)) {
       all_sim_venables <- furrr::future_map(
         .x = all_sim,
         .f = venables,

diff --git a/tests/tests_rafa/test_rafa.R b/tests/tests_rafa/test_rafa.R
@@ -1,7 +1,7 @@
 
 
 ##### Coverage ------------------------
-library(uci)
+# library(uci)
 library(testthat)
 library(covr)
 Sys.setenv(NOT_CRAN = "true")

diff --git a/tests/testthat/test_uci.R b/tests/testthat/test_uci.R
@@ -31,6 +31,9 @@ test_that("expected behavior", {
   result <- tester(parallel = TRUE)
   testthat::expect_is(result, "data.frame")
 
+  result <- tester(parallel = TRUE, bootstrap_border = TRUE)
+  testthat::expect_is(result, "data.frame")
+
   result <- tester(bootstrap_border = TRUE, showProgress = TRUE)
   testthat::expect_is(result, "data.frame")