Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build intro vignette #12

Closed
rafapereirabr opened this issue Aug 15, 2020 · 4 comments
Closed

build intro vignette #12

rafapereirabr opened this issue Aug 15, 2020 · 4 comments
Assignees
@dhersz @mvpsaraiva @rafapereirabr @kauebraga
Labels
priority

Comments

@rafapereirabr
Copy link
Member

rafapereirabr commented Aug 15, 2020 •
edited
Loading

1st (incomplete) draft here
@rafapereirabr
Copy link
Member Author

Since we are fastly approaching CRAN submission, this issue enters our priority list.

@rafapereirabr
Copy link
Member Author

rafapereirabr commented Aug 22, 2020 •
edited
Loading

Hi all. I've finished a first version of the r5r vignette. Please have a look and feel free to edit or comment with suggestions. I confess that the size of the ggplot2 and mapview outputs look too small for my taste, but I couldn't find a way to expand them. any ideas?

devtools::build_vignettes()

@rafapereirabr
Copy link
Member Author

Hi all. I've finished the intro vignette. I'm closing this issue for now, but please feel free to reopen it if you have any suggestions

@dhersz
Copy link
Member

dhersz commented Aug 25, 2020

I have made some tweaks in 03f4756.

Notably:

  • Stressed the importance of allocating memory before attaching r5r.
  • Changed a max_walk_dist argument from 5 to 5000 (in the travel time matrix, if I'm not mistaken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhersz dhersz

@mvpsaraiva mvpsaraiva

@rafapereirabr rafapereirabr

@kauebraga kauebraga

Labels
priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhersz @mvpsaraiva @rafapereirabr @kauebraga