Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Embed.php to use correct DocTypes #1

Closed
StevenWillett opened this issue Dec 8, 2017 · 2 comments
Closed

Updated Embed.php to use correct DocTypes #1

StevenWillett opened this issue Dec 8, 2017 · 2 comments

Comments

@StevenWillett
Copy link
Contributor

I have forked and updated the Embed.php file to use correct DocTypes and includes use case that was also missing.

Tried to create pull request, but not able, possibly disabled :)

See fork here: https://github.com/StevenWillett/metabase-php

Hope this helps others.

@ipeevski
Copy link
Owner

ipeevski commented Dec 8, 2017

Hey Steven, thanks for your contribution.
Let's try to figure out how to do the pull request so it keeps your attribution. I haven't disabled anything and can't seem to find an option about it. How did you try to do it?

ipeevski pushed a commit that referenced this issue Dec 8, 2017
@ipeevski
Copy link
Owner

ipeevski commented Dec 8, 2017

I figured it out. Pull requested and merged :)

@ipeevski ipeevski closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants